Re: [PATCH RESEND] ASoC: pxa: remove unused variable
From: Arnd Bergmann
Date: Fri Feb 26 2016 - 08:47:06 EST
On Friday 26 February 2016 10:18:27 Mark Brown wrote:
> On Thu, Feb 25, 2016 at 11:02:04PM +0100, Arnd Bergmann wrote:
>
> > Submitted originally on Nov 23 2015, this apparently got lost,
> > resending it now.
>
> You didn't really submit it, you pasted it into the middle of a reply to
> a message on an existing thread for a patch that was already applied:
>
> https://lkml.org/lkml/2015/11/23/88
>
> That's not really submitting a patch as far as I'm concerned, something
> that won't just apply with git am without special faffing isn't helping
> and things in the middle of threads aren't good either (it gets
> difficult to follow and there's every chance they'll never even get seen
> if they're buried in the middle of a reply where you don't expect to see
> a patch).
I see your point about the patch being in the middle of the thread.
Regarding the 'git am' compatibility, I thought I'd done it right,
but see now that I used incorrect scissors, apparently 'git mailinfo'
expects at least six '-' characters as the separator, while I used
just three.
Arnd