Re: [PATCH] bsp: add SoC device to brcmstb

From: Arnd Bergmann
Date: Fri Feb 26 2016 - 08:58:49 EST


On Thursday 25 February 2016 16:19:07 Justin Chen wrote:
> */
> void brcmstb_biuctrl_init(void);
>
> +/*
> + * Helper functions for getting family or product id from the
> + * SoC driver.
> + */
> +u32 brcmstb_get_family_id(void);
> +u32 brcmstb_get_product_id(void);
> +
> #endif /* __BRCMSTB_SOC_H */
> --

Please remove the declarations from the header file and make the
variable local to this file, to make sure no other driver accidentally
accesses them.

Arnd