Re: [PATCH v2 2/3] hvc_xen: fix xenboot for DomUs

[Stefano Stabellini]

On Fri, 26 Feb 2016, Boris Ostrovsky wrote:
> On 02/26/2016 10:39 AM, Stefano Stabellini wrote:
> > On Thu, 25 Feb 2016, Boris Ostrovsky wrote:
> > > On 02/25/2016 07:10 AM, Stefano Stabellini wrote:
> > > > The xenboot early console has been partially broken for DomU for a long
> > > > time: the output would only go to the hypervisor via hypercall
> > > > (HYPERVISOR_console_io), while it wouldn't actually go to the DomU
> > > > console. The reason is that domU_write_console would return early as no
> > > > xencons structs are configured for it.
> > > > 
> > > > Add an appropriate xencons struct for xenboot from the xenboot setup
> > > > callback.
> > > > 
> > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > > > 
> > > > ---
> > > > Changes in v2:
> > > > - add return to xenboot_setup_console
> > > > ---
> > > >    drivers/tty/hvc/hvc_xen.c |   32 ++++++++++++++++++++++++++------
> > > >    1 file changed, 26 insertions(+), 6 deletions(-)
> > > > 
> > > > diff --git a/drivers/tty/hvc/hvc_xen.c b/drivers/tty/hvc/hvc_xen.c
> > > > index 68b8ec8..bf787aa 100644
> > > > --- a/drivers/tty/hvc/hvc_xen.c
> > > > +++ b/drivers/tty/hvc/hvc_xen.c
> > > > @@ -246,6 +246,18 @@ err:
> > > >    	return -ENODEV;
> > > >    }
> > > >    +static int xen_early_pv_console_init(struct xencons_info *info, int
> > > > vtermno)
> > > Nit: not sure whether "early" is the right word to use here: when called
> > > from
> > > xen_pv_console_init() it's not really on the early path.
> > What about xencons_info_pv_init?
> 
> Sure, that sounds good.
> 
> (BTW, I didn't mean that my R-b was conditional on this)

No problem. I made this change and committed the three patches to
for-linus-4.6, based on v4.5-rc5.