Re: [PATCH 3/3] 3c59x: Use setup_timer()

[Stafford Horne]

On Thu, 25 Feb 2016, David Miller wrote:

> From: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
> Date: Wed, 24 Feb 2016 19:28:19 +0530
>
> > Convert a call to init_timer and accompanying intializations of
> > the timer's data and function fields to a call to setup_timer.
> >
> > The Coccinelle semantic patch that fixes this problem is
> > as follows:
> >
> > // <smpl>
> > @@
> > expression t,f,d;
> > @@
> >
> > -init_timer(&t);
> > +setup_timer(&t,f,d);
> >  ...
> > -t.data = d;
> > -t.function = f;
> > // </smpl>
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
>
> Applied.

Hi David, Amitoj,

The patch here seemed to remove the call to add_timer(&vp->timer) which
applies the expires time. Would that be an issue?

-Stafford