Re: log spammed with "loading xx failed with error -2" since commit e40ba6d56b [replace call to fw_read_file_contents() with kernel version]

[Luis R. Rodriguez]

On Sat, Feb 27, 2016 at 05:49:38PM +0100, Heiner Kallweit wrote:
> Since this commit my system log is spammed with firmware load errors. One example:
> 
> loading /lib/firmware/updates/4.5.0-rc5-next-20160226/iwlwifi-3160-16.ucode failed with error -2
> loading /lib/firmware/updates/iwlwifi-3160-16.ucode failed with error -2
> loading /lib/firmware/4.5.0-rc5-next-20160226/iwlwifi-3160-16.ucode failed with error -2
> -> finally load attempt from /lib/firmware/iwlwifi-3160-16.ucode succeeds
> 
> Before this commit, when a load from one path in fw_path failed, silently the next path was tried.
> Only if all attempts failed an error message was printed.
> Now for each single failed attempt an error message is printed what doesn't make sense.

To be clear, this is an issue on linux-next, due to the latest merge
of Mimi's common kernel file loader pulled recently by James.

Heiner, thanks for the report, this patch fixes that. I'll be submitting that
now.  James, should this go through your tree? Please note I've been meaning to
add myself to MAINTAINERS for FIRMWARE_CLASS as requested by Greg at kernel
summit as I've been helping with cleanup there but I hadn't done so as I had
some pending patches with a full new functionality added. With Mimi's changes
merged on linux-next though and the common kernel file loader now done I can
follow up with my series of changes after this.

  Luis