Re: [PATCH 1/7] extcon: palmas: Drop IRQF_EARLY_RESUME flag
From: Chanwoo Choi
Date: Sun Feb 28 2016 - 21:22:46 EST
Hi Grygorii,
On 2016ë 02ì 27ì 00:42, Grygorii Strashko wrote:
> Palams extcon IRQs are nested threaded and wired to the Palmas
> inerrupt controller. So, this flag is not required for nested irqs
> anymore, since commit 3c646f2c6aa9 ("genirq: Don't suspend
> nested_thread irqs over system suspend") was merged.
>
> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Roger Quadros <rogerq@xxxxxx>
> Cc: Nishanth Menon <nm@xxxxxx>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> ---
> drivers/extcon/extcon-palmas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 93c30a8..0a861b3 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -266,7 +266,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
> palmas_usb->id_irq,
> NULL, palmas_id_irq_handler,
> IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> - IRQF_ONESHOT | IRQF_EARLY_RESUME,
> + IRQF_ONESHOT,
> "palmas_usb_id", palmas_usb);
> if (status < 0) {
> dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
> @@ -304,7 +304,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
> palmas_usb->vbus_irq, NULL,
> palmas_vbus_irq_handler,
> IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> - IRQF_ONESHOT | IRQF_EARLY_RESUME,
> + IRQF_ONESHOT,
> "palmas_usb_vbus", palmas_usb);
> if (status < 0) {
> dev_err(&pdev->dev, "can't get IRQ %d, err %d\n",
>
Applied it on extcon git.
Thanks,
Chanwoo Choi