Re: [PATCH 01/18] mm: Make mmap_sem for write waits killable for mm syscalls

From: kbuild test robot
Date: Mon Feb 29 2016 - 08:45:18 EST

Hi Michal,

[auto build test WARNING on next-20160229]
[also build test WARNING on v4.5-rc6]
[cannot apply to drm/drm-next drm-intel/for-linux-next v4.5-rc6 v4.5-rc5 v4.5-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url: https://github.com/0day-ci/linux/commits/Michal-Hocko/change-mmap_sem-taken-for-write-killable/20160229-213258
config: i386-randconfig-x003-201609 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

In file included from include/asm-generic/bug.h:4:0,
from arch/x86/include/asm/bug.h:35,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/mm.h:8,
from mm/util.c:1:
mm/util.c: In function 'vm_mmap_pgoff':
mm/util.c:331:8: error: implicit declaration of function 'down_write_killable' [-Werror=implicit-function-declaration]
if (down_write_killable(&mm->mmap_sem))
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
>> mm/util.c:331:4: note: in expansion of macro 'if'
if (down_write_killable(&mm->mmap_sem))
^
cc1: some warnings being treated as errors
--
In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/uapi/linux/capability.h:16,
from include/linux/capability.h:15,
from mm/mlock.c:8:
mm/mlock.c: In function 'do_mlock':
mm/mlock.c:638:6: error: implicit declaration of function 'down_write_killable' [-Werror=implicit-function-declaration]
if (down_write_killable(&current->mm->mmap_sem))
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
>> mm/mlock.c:638:2: note: in expansion of macro 'if'
if (down_write_killable(&current->mm->mmap_sem))
^
cc1: some warnings being treated as errors
--
In file included from include/linux/linkage.h:4:0,
from include/linux/kernel.h:6,
from mm/mmap.c:11:
mm/mmap.c: In function 'SYSC_brk':
mm/mmap.c:185:6: error: implicit declaration of function 'down_write_killable' [-Werror=implicit-function-declaration]
if (down_write_killable(&mm->mmap_sem))
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
>> mm/mmap.c:185:2: note: in expansion of macro 'if'
if (down_write_killable(&mm->mmap_sem))
^
cc1: some warnings being treated as errors
--
In file included from include/asm-generic/bug.h:4:0,
from arch/x86/include/asm/bug.h:35,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/mm.h:8,
from mm/mprotect.c:11:
mm/mprotect.c: In function 'SYSC_mprotect':
mm/mprotect.c:381:6: error: implicit declaration of function 'down_write_killable' [-Werror=implicit-function-declaration]
if (down_write_killable(&current->mm->mmap_sem))
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
>> mm/mprotect.c:381:2: note: in expansion of macro 'if'
if (down_write_killable(&current->mm->mmap_sem))
^
cc1: some warnings being treated as errors
--
In file included from include/asm-generic/bug.h:4:0,
from arch/x86/include/asm/bug.h:35,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/mm.h:8,
from mm/mremap.c:10:
mm/mremap.c: In function 'SYSC_mremap':
mm/mremap.c:505:6: error: implicit declaration of function 'down_write_killable' [-Werror=implicit-function-declaration]
if (down_write_killable(&current->mm->mmap_sem))
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
>> mm/mremap.c:505:2: note: in expansion of macro 'if'
if (down_write_killable(&current->mm->mmap_sem))
^
cc1: some warnings being treated as errors
--
In file included from include/asm-generic/bug.h:4:0,
from arch/x86/include/asm/bug.h:35,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/mm.h:8,
from include/linux/mman.h:4,
from mm/madvise.c:8:
mm/madvise.c: In function 'SYSC_madvise':
mm/madvise.c:768:7: error: implicit declaration of function 'down_write_killable' [-Werror=implicit-function-declaration]
if (down_write_killable(&current->mm->mmap_sem))
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
>> mm/madvise.c:768:3: note: in expansion of macro 'if'
if (down_write_killable(&current->mm->mmap_sem))
^
cc1: some warnings being treated as errors

vim +/if +331 mm/util.c

315 {
316 return get_user_pages_unlocked(start, nr_pages, write, 0, pages);
317 }
318 EXPORT_SYMBOL_GPL(get_user_pages_fast);
319
320 unsigned long vm_mmap_pgoff(struct file *file, unsigned long addr,
321 unsigned long len, unsigned long prot,
322 unsigned long flag, unsigned long pgoff, bool killable)
323 {
324 unsigned long ret;
325 struct mm_struct *mm = current->mm;
326 unsigned long populate;
327
328 ret = security_mmap_file(file, prot, flag);
329 if (!ret) {
330 if (killable) {
> 331 if (down_write_killable(&mm->mmap_sem))
332 return -EINTR;
333 } else {
334 down_write(&mm->mmap_sem);
335 }
336 ret = do_mmap_pgoff(file, addr, len, prot, flag, pgoff,
337 &populate);
338 up_write(&mm->mmap_sem);
339 if (populate)

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data