Re: [PATCH 07/18] mm, proc: make clear_refs killable

From: Michal Hocko
Date: Mon Feb 29 2016 - 13:02:10 EST


On Mon 29-02-16 18:58:17, Oleg Nesterov wrote:
> On 02/29, Michal Hocko wrote:
> >
> > On Mon 29-02-16 18:38:45, Oleg Nesterov wrote:
> >
> > > In this case you do not need put_task_struct().
> >
> > Why not? Both are after get_proc_task which takes a reference to the
> > task...
>
> Yes, but we already have put_task_struct(task) in the "out_mm" path, so
> "goto out_mm" should work just fine?

OK, got what you mean now. That's what I did and is on the way. I just
thought you mean that put_task_struct is implicit for other reason.

--
Michal Hocko
SUSE Labs