Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding

[Aravind Gopalakrishnan]

On 3/2/2016 10:21 AM, Borislav Petkov wrote:
> On Wed, Mar 02, 2016 at 09:52:23AM -0600, Aravind Gopalakrishnan wrote:
> > So, I think we should continue this approach and have something like this-
> > static const char * const amd_core_mcablock_names[] = {
> >          [SMCA_LS]         = "load_store",
> >          [SMCA_IF]         = "insn_fetch",
> >          [SMCA_L2_CACHE]   = "l2_cache",
> >          [SMCA_DE]         = "decode_unit",
> >          [RES]                   = "",
> >          [SMCA_EX]         = "execution_unit",
> >          [SMCA_FP]         = "floating_point",
> >          [SMCA_L3_CACHE]   = "l3_cache",
> > };
> >
> > static const char * const amd_df_mcablock_names[] = {
> >          [SMCA_CS]  = "coherent_slave",
> >          [SMCA_PIE] = "pie",
> > };
> >
> > (Split arrays again because I feel it'd be better to have arrays ordered
> > according to mca_type values)
> Ok, care to take the patch and redo it as you suggest?

Sure. I was going to introduce these strings as part of patch to update 
sysfs code to
understand the new banks anyway. So it's already in the works:)

> I really don't want to be assigning strings each time during decoding.

Ok, Will update the EDAC to use the existing string array.

> Also, make sure the strings are as human readable as possible and so
> that users can at least have an idea what we're saying. "load_store"
> is better than "LS", "insn_fetch" is better than "IF", etc. Some
> abbreviations should remain, though. "platform_security_processor" is
> yucky and I guess there we can stick to "PSP". Ditto for "SMU"...

Understood. Will do as you suggest.

> Making the unabbreviated lowercase for sysfs usage is fine too, of
> course.

So, have you pushed the set of patches you applied somewhere? (bp.git?)
I can work on top of those and it will be easier to rebase on top of tip.git
once the patches find their way there..

Thanks,
-Aravind.