RE: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver

From: Chrzaniuk, Hubert
Date: Tue Mar 08 2016 - 04:18:51 EST

-----Original Message-----
From: Borislav Petkov [mailto:bp@xxxxxxxxx]
Sent: Monday, March 7, 2016 4:24 PM

> Do I see it correctly this one fixes
> d0cdf9003140 ("EDAC, sb_edac: Add Knights Landing (Xeon Phi gen 2) support")
> and needs to go to Linus now otherwise 4.5 is b0rked on KNL?

Yes, thatâs right:
1. d0cdf9003140 is the patch I am referring to
2. EDAC for KNL platform on 4.5 will not cause any problems but will not be functional for DIMMs (only for MCDRAM)

> On a related note, that knl_get_dimm_capacity() is huuuge and hard to
> read and could use some nice cleanups and splitting out functionality
> into helper functions...

Thanks, that is a valid point, it will be refactored in a separate patch.
However it would good to fix what we have now, so I still hope to have the patch merged anyway...