Re: [PATCH V2] PM / clk: Add support for obtaining clocks from device-tree

From: Jon Hunter
Date: Wed Mar 09 2016 - 11:58:11 EST

On 09/03/16 14:04, Rafael J. Wysocki wrote:
> On Wed, Mar 9, 2016 at 2:13 PM, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>> The PM clocks framework requires clients to pass either a con-id or a
>> valid clk pointer in order to add a clock to a device. Add a new
>> function of_pm_clk_add_clks() to allows device clocks to be retrieved
>> from device-tree and populated for a given device. Note that
>> of_clk_get_from_provider() is not defined if CONFIG_OF and
>> CONFIG_COMMON_CLK are not selected. Therefore, make of_pm_clk_add_clks()
>> dependent on these options.
>> An optional function pointer may be passed to of_pm_clk_add_clks() that
>> can be used to filter the clocks that are added for a device when
>> calling of_pm_clk_add_clks().
>> In order to handle errors encountered when adding clocks from
>> device-tree, add a function pm_clk_remove_clk() to remove any clocks
>> (using a pointer to the clk structure) that have been added
>> successfully before the error occurred.
>> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>> ---
>> Changes v1-v2:
>> - Added support for optional filter function as suggested by Geert U.
> I'd like to get an ACK on this from someone more familiar with the DT
> stuff than I am.

No problem. Is Geert's ACK sufficient or is there someone else I should add?