Re: [PATCH] net: mvneta: Add missing hotplug notifier transition

From: Thomas Gleixner
Date: Fri Mar 11 2016 - 05:50:25 EST


On Fri, 11 Mar 2016, Gregory CLEMENT wrote:
> On ven., mars 11 2016, Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx> wrote:
> > The mvneta_percpu_notifier() hotplug callback lacks handling of the
> > CPU_DOWN_FAILED case. That means, if CPU_DOWN_PREPARE failes, the
> > driver is not well configured on the CPU.
> >
> > Add handling for CPU_DOWN_FAILED[_FROZEN] hotplug notifier transition
> > to setup the driver.
> I agree that we need to handle this case, however reusing CPU_ONLINE
> case for it seems too much.

Why is that too much? If it does the job, then it's definitely preferrable
over an extra case for a non hotpath error handling operation.