Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt

[Sergei Shtylyov]

Hello.

On 3/11/2016 4:53 AM, Daode Huang wrote:

> > > In V2 chip, when sending mamagement packets, the driver should
> > > config the port id to BD descs.
> > >
> > > Signed-off-by: Daode Huang <huangdaode@xxxxxxxxxxxxx>
> > > Signed-off-by: Lisheng <lisheng011@xxxxxxxxxx>
> > > ---
> > >   drivers/net/ethernet/hisilicon/hns/hnae.h         | 3 +++
> > >   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 +
> > >   drivers/net/ethernet/hisilicon/hns/hns_enet.c     | 4 ++++
> > >   3 files changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h
> > > b/drivers/net/ethernet/hisilicon/hns/hnae.h
> > > index 1cbcb9f..11a3f97 100644
> > > --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
> > > +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
> > [...]
> > > @@ -516,6 +518,7 @@ struct hnae_handle {
> > >       int q_num;
> > >       int vf_id;
> > >       u32 eport_id;
> > > +    u32 dport_id;    /*v2 tx bd should fill the dport_id*/
> >
> >    Please add spaces after /* and before */ (like it's done in other places
> > in this driver).
>
> Hi MBR, Sergei,

   Just in case: MBR stands for "my best regards", Sergei is my name. :-)

> Daode.

MBR, Sergei