Re: [PATCH] gpio: xgene: Fix kconfig for standby GIPO contoller
From: Matthias Brugger
Date: Fri Mar 11 2016 - 15:12:15 EST
On Fri, 2016-03-11 at 23:01 +0700, Linus Walleij wrote:
> On Fri, Mar 4, 2016 at 5:59 PM, Matthias Brugger <mbrugger@xxxxxxxx>
> wrote:
>
> > The standby GPIO controller can be used as a interrupt controller.
> > Select GPIOLIB_IRQCHIP when compiling this driver. Otherwise we get
> > a compilation error:
> >
> > drivers/gpio/gpio-xgene-sb.c: In function 'xgene_gpio_sb_probe':
> > drivers/gpio/gpio-xgene-sb.c:312:10: error: 'struct gpio_chip' has
> > no member named 'irqdomain'
> > priv->gc.irqdomain = priv->irq_domain;
> > ^
> > scripts/Makefile.build:295: recipe for target 'drivers/gpio/gpio
> > -xgene-sb.o' failed
> > make[2]: *** [drivers/gpio/gpio-xgene-sb.o] Error 1
> >
> > Fixes: 1013fc41 "gpio: xgene: Enable X-Gene standby GPIO as
> > interrupt controller"
> > Signed-off-by: Matthias Brugger <mbrugger@xxxxxxxx>
>
> Quan's patch exporting the symbols has been merged by tglx
> so dropping this.
>
Thanks for the info.
Actually this is v1 [1] of the patch, which just addresses the
GPIOLIB_IRQCHIP problem?
With Quan's patch this should still be present.
[1] https://patchwork.kernel.org/patch/8502401/