Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable CONFIG_REGULATOR_PWM=y

[Thierry Reding]

On Sat, Mar 12, 2016 at 08:51:40PM +0800, Andy Yan wrote:
> Some platform like Rockchip rk3066 use pwm as a regulator to modulate
> cpu voltage, so pwm regulator should be enabled at system boot time if
> the system want to run with high frequency.
> 
> Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxxxxxxx>
> ---
> 
>  arch/arm/configs/multi_v7_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This really belongs in patch 1/2. But then the same comments hold true
and I think you'll need to come up with a proper fix that prevents the
switch to a higher frequency if don't have the necessary regulator, or
make the Kconfig symbol bool if all else fails.

If you make the Kconfig symbol bool I'd expect a really good explanation
in the commit message as to why it can't be fixed properly.

Thierry

Attachment: signature.asc
Description: PGP signature