Re: [RFC 1/9] mm/hugetlb: Make GENERAL_HUGETLB functions PGD implementation aware

From: Andrew Morton
Date: Mon Mar 14 2016 - 16:29:30 EST


On Fri, 11 Mar 2016 08:31:55 +0530 Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx> wrote:

> On 03/09/2016 05:40 PM, Anshuman Khandual wrote:
> > Currently both the ARCH_WANT_GENERAL_HUGETLB functions 'huge_pte_alloc'
> > and 'huge_pte_offset' dont take into account huge page implementation
> > at the PGD level. With addition of PGD awareness into these functions,
> > more architectures like POWER which also implements huge pages at PGD
> > level (along with PMD level), can use ARCH_WANT_GENERAL_HUGETLB option.
>
> Hugh/Mel/Naoya/Andrew,
>
> Thoughts/inputs/suggestions ? Does this change looks okay ?

Patches 1, 2 and 3 look OK to me. Please include them in the powerpc
merge when the patchset is considered ready.