Re: [PATCH 11/17] dt-bindings: Add PLX Technology OXNAS pinctrl and gpio bindings
From: Linus Walleij
Date: Tue Mar 15 2016 - 10:30:13 EST
On Thu, Mar 3, 2016 at 12:40 PM, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:
This is a vert terse zero-line commit message. Atleast describe what you are
trying to do.
> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> +optional properties:
> +- #gpio-lines: Number of gpio if absent 32.
NACK, use ngpio from the gpio.txt document like
> +Required properties for iomux controller:
> +- compatible: "plxtech,nas782x-pinctrl" or "plxtech,ox810se-pinctrl"
> +- plxtech,mux-mask: array of mask (periph per bank) to describe if a pin can be
> + configured in this periph mode. All the periph and bank need to be describe.
Why? Encode this into the driver and select muxmask from
the compatible string if it is a hardware limitation.
> +Each column will represent the possible peripheral of the pinctrl
> +Each line will represent a pio bank
> +For example :
> +Peripheral: 2 ( A and B)
> +Bank: 2 (A, B and C)
> + /* A B */
> + 0xffffffff 0xffc00c3b /* pioA */
> + 0xffffffff 0x7fff3ccf /* pioB */
> +For each peripheral/bank we will descibe in a u32 if a pin can be
> +configured in it by putting 1 to the pin bit (1 << pin)
That's just completely hopeless to understand for a DT author.
Put it into the driver.
> +Required properties for pin configuration node:
> +- plxtech,pins: 4 integers array, represents a group of pins mux and config
> + setting. The format is plxtech,pins = <PIN_BANK PIN_BANK_NUM PERIPH CONFIG>.
> + The PERIPH 0 means gpio, PERIPH 1 is periph A, PERIPH 2 is periph B...
> + PIN_BANK 0 is pioA, PIN_BANK 1 is pioB...
NACK, use the standard binding for "pins" from pinctrl-bindings.txt
Also make the driver use the existing helpers for this property.