Re: [PATCH V7 05/12] thermal: tegra: add Tegra210 specific SOC_THERM driver

[Eduardo Valentin]

On Tue, Mar 15, 2016 at 02:59:52PM +0800, Wei Ni wrote:
> 
> 
> On 2016å03æ15æ 02:57, Eduardo Valentin wrote:
> > * PGP Signed by an unknown key
> > 
> > On Fri, Mar 11, 2016 at 11:10:25AM +0800, Wei Ni wrote:
> >> Add Tegra210 specific SOC_THERM driver.
> >>
> >> Signed-off-by: Wei Ni <wni@xxxxxxxxxx>
> >> ---
> >>  drivers/thermal/tegra/Makefile            |   1 +
> >>  drivers/thermal/tegra/soctherm-fuse.c     |  11 ++
> >>  drivers/thermal/tegra/soctherm.c          |   6 ++
> >>  drivers/thermal/tegra/soctherm.h          |   4 +
> >>  drivers/thermal/tegra/tegra210-soctherm.c | 173 ++++++++++++++++++++++++++++++
> > 
> > No Kconfig change?
> 
> Yes, we doesn't need Kconfig change.
> 
> As discussed with Thierry in [V1,03/10] thermal: tegra: split tegra_soctherm
> driver, he said:
> "I'd like to do this differently to reduce the number of Kconfig symbols.
> The alternate proposal would be for the TEGRA_SOCTHERM symbol to remain
> as it is and then build in driver support depending on the selected
> ARCH_TEGRA_*_SOC options."
> 
> So we only have "config TEGRA_SOCTHERM" in the Kconfig, and in Makefile, we add
> tegra-soctherm-$(CONFIG_ARCH_TEGRA_124_SOC)	+= tegra124-soctherm.o
> tegra-soctherm-$(CONFIG_ARCH_TEGRA_210_SOC)	+= tegra210-soctherm.o


makes sense to me.

Attachment: signature.asc
Description: Digital signature