Re: [PART1 RFC v2 07/10] svm: Add VMEXIT handlers for AVIC

From: Paolo Bonzini
Date: Thu Mar 17 2016 - 05:35:17 EST




On 17/03/2016 04:58, Suravee Suthikulpanit wrote:
>>>
>>> >+ BUG_ON(offset >= 0x400);
>> These are valid faulting registers, so our implementation has to handle
>> them. (And the rule is to never BUG if a recovery is simple.)
>>
>
> Just want to clarify the part that you mentioned "to handle them". IIUC,
> offet 0x400 and above are for x2APIC stuff, which AVIC does not
> currently support. Also, since I have only advertised as xAPIC when
> enabling AVIC, if we run into the situation that the VM is trying to
> access these register, we should just ignore it (and not BUG). Do I
> understand that correctly?

Yes. You can add a printk(KERN_DEBUG) though.

Paolo