Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()

From: Rob Clark
Date: Thu Mar 17 2016 - 17:25:56 EST


On Thu, Mar 17, 2016 at 5:19 PM, Gustavo Padovan <gustavo@xxxxxxxxxxx> wrote:
> 2016-03-17 Joe Perches <joe@xxxxxxxxxxx>:
>
>> On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
>> > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
>> []
>> > > It's a name that seems like it should be a straightforward
>> > > cast of a kernel pointer to a __user pointer like:
>> > >
>> > > static inline void __user *to_user_ptr(void *p)
>> > > {
>> > > return (void __user *)p;
>> > > }
>> > ahh, ok. I guess I was used to using it in the context of ioctl
>> > structs.. in that context u64 -> (void __user *) made more sense.
>> >
>> > Maybe uapi_to_ptr()? (ok, not super-creative.. maybe someone has a
>> > better idea)
>>
>> Maybe u64_to_user_ptr?
>
> That is a good name. If everyone agrees I can resend this patch
> changing it to u64_to_user_ptr. Then should we still keep it on
> kernel.h?


works for me

BR,
-R