Re: [PATCH] fence: add missing descriptions for fence
From: Javier Martinez Canillas
Date: Sat Mar 19 2016 - 19:55:35 EST
Hello Luis,
On Sat, Mar 19, 2016 at 4:50 PM, Luis de Bethencourt
<luisbg@xxxxxxxxxxxxxxx> wrote:
> Commit b55b54b5db33 ("staging/android: remove struct sync_pt")
> added the members child_list and active_list to the fence struct, but
> didn't add descriptions for these. Adding the descriptions.
>
Patches whose commit message mentions a specific commit that
introduced and issue, usually also have a "Fixes:" tag before the
S-o-B. For example this patch should have:
Fixes: b55b54b5db33 ("staging/android: remove struct sync_pt")
> Signed-off-by: Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx>
> ---
> Hi,
>
> Noticed this missing descriptions when running make htmldocs.
>
> Got the following warnings:
> .//include/linux/fence.h:84: warning: No description found for parameter 'child_list'
> .//include/linux/fence.h:84: warning: No description found for parameter 'active_list'
>
> Thanks :)
> Luis
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Best regards,
Javier