Re: [PATCH 1/4] KVM: MMU: fix permission_fault()

From: Paolo Bonzini
Date: Fri Mar 25 2016 - 09:50:11 EST




On 25/03/2016 14:41, Xiao Guangrong wrote:
>>>
>>
>> So is this patch doing the same as "KVM: MMU: precompute page fault
>> error code"? It was necessary after all. :)
>
> Sorry for my mistake... I missed the logic you changed :(
>
> I still prefer to calculating the error code on the fault path which is
> rare, or think a way to encapsulate it to permission_fault()...

Yes, I will apply your patch.

Paolo