Re: [GIT PULL] f2fs updates for v4.6

[Jaegeuk Kim]

On Sat, Mar 26, 2016 at 01:10:07AM -0500, Eric Biggers wrote:
> Why was the XTS tweak initialization changed in commit 0b81d0779072 ("fs crypto:
> move per-file encryption from f2fs tree to fs/crypto")?
> 
> Old code:
> 
>        memcpy(xts_tweak, &index, sizeof(index));
>        memset(&xts_tweak[sizeof(index)], 0,
>                        F2FS_XTS_TWEAK_SIZE - sizeof(index));
> 
> New code:
>        memcpy(xts_tweak, &inode->i_ino, sizeof(index));
>        memset(&xts_tweak[sizeof(index)], 0,
>                        FS_XTS_TWEAK_SIZE - sizeof(index));
> 
> Now the XTS tweak is the same for all pages of each inode.

Thank you for catching this.
I've checked several times, but turns out I missed something tho. :(
Let me write a patch to fix this.

Thanks,