Re: [PATCH] HID: lenovo: Don't use stack variables for DMA buffers

From: Jiri Kosina
Date: Tue Mar 29 2016 - 09:41:03 EST


On Tue, 29 Mar 2016, Benjamin Tissoires wrote:

> > The lenovo_send_cmd_cptkbd function uses a stack variable to submit
> > commands via hid_hw_raw_request. Eventually this gets to the
> > usb_hcd_map_urb_for_dma function, which causes a warning to be thrown
> > if the CONFIG_DMA_API_DEBUG option is enabled.
> >
> > Fix this by allocating a temporary buffer instead.
> >
> > Reported-by: lejeczek <peljasz@xxxxxxxxxxx>
> > Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
> > ---
>
> The patch is
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
>
> There is just one nitpick that can be solved while committing (or not,
> depending on how Jiri handles it :-P ).

I've nuked the NULL-initialization and applied, thanks!

--
Jiri Kosina
SUSE Labs