[PATCH] drivers/mtd/chips/cfi_cmdset_0020.c: Deinline do_erase_oneblock

From: Denys Vlasenko
Date: Wed Mar 30 2016 - 09:01:16 EST


This function compiles to 2142 bytes of machine code.
In C, the function is about 150 lines long.

It has only one callsite, but forced inlining that much code
makes gcc generate worse code. Let gcc itself decide what to do.

text data bss dec hex filename
95943075 20860288 35991552 152794915 91b7723 vmlinux_before
95942947 20860288 35991552 152794787 91b76a3 vmlinux

Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
CC: David Woodhouse <David.Woodhouse@xxxxxxxxx>
CC: Brian Norris <computersforpeace@xxxxxxxxx>
CC: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
CC: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
CC: linux-kernel@xxxxxxxxxxxxxxx
---
drivers/mtd/chips/cfi_cmdset_0020.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
index 9a1a6ff..c740bd2 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -728,7 +728,7 @@ write_error:
}


-static inline int do_erase_oneblock(struct map_info *map, struct flchip *chip, unsigned long adr)
+static int do_erase_oneblock(struct map_info *map, struct flchip *chip, unsigned long adr)
{
struct cfi_private *cfi = map->fldrv_priv;
map_word status, status_OK;
--
2.1.0