Re: [PATCH v2 5/5] lib: scatterlist: move SG pool code from SCSI driver to lib/sg_pool.c

[Ming Lin]

On Mon, Apr 4, 2016 at 1:17 PM, Christoph Hellwig <hch@xxxxxx> wrote:
> On Mon, Apr 04, 2016 at 01:15:45PM -0700, Ming Lin wrote:
>> cleanup_sdb:
>>         for (i = 0; i < SG_MEMPOOL_NR; i++) {
>>                 struct sg_pool *sgp = sg_pools + i;
>>                 if (sgp->pool)
>>                         mempool_destroy(sgp->pool);
>>                 if (sgp->slab)
>>                         kmem_cache_destroy(sgp->slab);
>>         }
>>
>> I'll keep the NULL check if no objection.
>
> I don't necessarily, but given that this is a code move I'd prefer
> to keep the code as similar as possible in the actual move patch..

So I'll just keep it.
And I can send a cleanup patch after this series applied.