Re: [PATCH 7/9] thermal: of: Add support for hardware-tracked trip points

[Sascha Hauer]

On Fri, Apr 22, 2016 at 09:54:19AM +0800, Caesar Wang wrote:
> Hi Brian, Eduardo, Sascha
> 
> å 2016å04æ21æ 09:12, Brian Norris åé:
> >+ Sascha
> >
> >On Wed, Apr 20, 2016 at 04:48:18PM -0700, Eduardo Valentin wrote:
> >>On Mon, Apr 18, 2016 at 11:35:59AM +0800, Caesar Wang wrote:
> >>>From: Mikko Perttunen <mperttunen@xxxxxxxxxx>
> >>>
> >>>This adds support for hardware-tracked trip points to the device tree
> >><cut>
> >>
> >>>diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> >>>index 97b86c5..6ef932a 100644
> >>>--- a/include/linux/thermal.h
> >>>+++ b/include/linux/thermal.h
> >>>@@ -335,12 +335,14 @@ struct thermal_genl_event {
> >>>   * @get_trend: a pointer to a function that reads the sensor temperature trend.
> >>>   * @set_emul_temp: a pointer to a function that sets sensor emulated
> >>>   *		   temperature.
> >>>+ * @set_trips: a pointer to a function that set low/high trip temperature.
> >>>   */
> >>>  struct thermal_zone_of_device_ops {
> >>>  	int (*get_temp)(void *, int *);
> >>>  	int (*get_trend)(void *, long *);
> >>>  	int (*set_emul_temp)(void *, int);
> >>>  	int (*set_trip_temp)(void *, int, int);
> >>>+	int (*set_trips)(void *, int, int);
> >>This is unfortunately a diverges from API available on thermal core. Can
> >>you please add first on thermal core then, use it in of thermal?
> >>
> >>I don't want to have callbacks available only via of thermal. If we
> >>allow it, OF thermal becomes a separate API.
> >What ever happened to this effort?
> >
> >http://thread.gmane.org/gmane.linux.power-management.general/59451
> >
> >Patch 12 and 13 look to accomplish something similar, yet they do what
> >Eduardo suggested. I was testing that series at my previous job, but
> >unfortunately (for the fate of this series) I left that employer before
> >I could finish reviewing and testing it. Perhaps Caesar can resurrect
> >and test it?
> 
> @Brian
> Yes, I can
> 
> Sure, I can.
> 
> I see the Sascha's newest thermal patches in patchwork.
> The following patches are still needed, right?
> 
> 6446191 New          [06/16] thermal: inline only once used function
> 6446111 New          [07/16] thermal: streamline get_trend callbacks
> 6445871 New          [08/16] thermal: Allow sensor ops to fail with -ENOSYS
> 6445861 New          [09/16] thermal: of: always set sensor related
> callbacks
> 6446221 New          [10/16] thermal: Make struct thermal_zone_device_ops
> const
> 6446201 New          [11/16] thermal: bang-bang governor: act on lower trip
> boundary
> 6445891 New          [12/16] thermal: thermal: Add support for
> hardware-tracked trip points
> 6445911 New          [13/16] thermal: of: implement .set_trips for device
> tree thermal zones
> 
> @Sascha, Eduardo
> Can you share your discussion content for the above patches as remembered?

These are still the newest patches. I won't have any resources in the
near future for continuing the work on them, so feel free to pick them
up. There hasn't been much discussion around these patches which was the
reason I abandoned them.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |