Re: [PATCH 15/20] tile: get rid of superfluous __GFP_REPEAT

[Chris Metcalf]

On 4/28/2016 9:24 AM, Michal Hocko wrote:
> From: Michal Hocko<mhocko@xxxxxxxx>
>
> __GFP_REPEAT has a rather weak semantic but since it has been introduced
> around 2.6.12 it has been ignored for low order allocations.
>
> pgtable_alloc_one uses __GFP_REPEAT flag for L2_USER_PGTABLE_ORDER but
> the order is either 0 or 3 if L2_KERNEL_PGTABLE_SHIFT for HPAGE_SHIFT.
> This means that this flag has never been actually useful here because it
> has always been used only for PAGE_ALLOC_COSTLY requests.
>
> Cc: Chris Metcalf<cmetcalf@xxxxxxxxxxxx>
> Cc:linux-arch@xxxxxxxxxxxxxxx
> Signed-off-by: Michal Hocko<mhocko@xxxxxxxx>
> ---
>   arch/tile/mm/pgtable.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

This seems OK as far as I can tell from code review.

Acked-by: Chris Metcalf <cmetcalf@xxxxxxxxxxxx> [for tile]

--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com