Re: [PATCH v2 1/2] ARM: bcm2835: dt: Add the ethernet to the device trees
From: Stefan Wahren
Date: Thu Apr 28 2016 - 12:26:57 EST
Hi Olivier
Am 28.04.2016 um 14:52 schrieb Olivier Blin:
> Stephen Warren <swarren@xxxxxxxxxxxxx> writes:
>
>> On 02/04/2016 12:36 AM, Lubomir Rintel wrote:
>>> The hub and the ethernet in its port 1 are hardwired on the board.
>>>
>>> Compared to the adapters that can be plugged into the USB ports, this
>>> one has no serial EEPROM to store its MAC. Nevertheless, the Raspberry Pi
>>> has the MAC address for this adapter in its ROM, accessible from its
>>> firmware.
>>>
>>> U-Boot can read out the address and set the local-mac-address property of the
>>> node with "ethernet" alias. Let's add the node so that U-Boot can do its
>>> business.
>>>
>>> Model B rev2 and Model B+ entries were verified by me, the hierarchy and
>>> pid/vid pair for the Version 2 was provided by Olivier Blin. Original
>>> Model B is a blind short, though very likely correct.
>> The series,
>> Tested-by: Stephen Warren <swarren@xxxxxxxxxxxxx>
>>
>> A few nits though...
> [...]
>
> Is this still being queued in some tree?
> Or does it need more fixes and a resubmit?
Yes, a V3 should address the comments from Peter and Stephen.
Regards
Stefan
>
> Without this, Raspberry Pi devices boot with a random MAC address.
>