Re: [PATCH] fix infoleak in wireless

[Greg Kroah-Hartman]

On Tue, May 03, 2016 at 05:11:07PM -0400, Kangjie Lu wrote:
> Opps, I did not notice the patch is not attached.
> 
> From 34a82a734388d07eb10f91770f86938e38f7575a Mon Sep 17 00:00:00 2001
> From: Kangjie Lu <kjlu@xxxxxxxxxx>
> Date: Tue, 3 May 2016 14:15:18 -0400
> Subject: [PATCH] fix infoleak in wireless
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The 6-bytes array âmac_addrâ is not initialized in the dump_station
> implementations of âdrivers/staging/wilc1000/wilc_wfi_cfgoperations.câ
> and âdrivers/staging/rtl8723au/os_dep/ioctl_cfg80211.câ, so all 6
> bytes may be leaked.
> 
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxxxxx>
> ---
> Ânet/wireless/nl80211.c | 1 +
> Â1 file changed, 1 insertion(+)
> 
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 056a730..2e92d14 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -3905,6 +3905,7 @@ static int nl80211_dump_station(struct sk_buff *skb,
> Â
> Â while (1) {
> Â memset(&sinfo, 0, sizeof(sinfo));
> + eth_zero_addr(mac_addr);
> Â err = rdev_dump_station(rdev, wdev->netdev, sta_idx,
> Â mac_addr, &sinfo);
> Â if (err == -ENOENT)

Patch is corrupted :(

Why not fix up the staging drivers, they are the real problem here,
which is what I think the networking maintainers were telling you to do.

thanks,

greg k-h