Re: linux/bitops.h

From: John Denker
Date: Wed May 04 2016 - 18:06:12 EST

Next message: Bjorn Helgaas: "Re: [PATCH [RFC]] PCI: hv: add explicit fencing to config space access"
Previous message: Grochowalski, Matthew (GE Aviation, US): "sched: Where to queue RT tasks on prio drop"
In reply to: H. Peter Anvin: "Re: [PATCH 1/3] random: replace non-blocking pool with a Chacha20-based CRNG"
Next in thread: Andi Kleen: "Re: linux/bitops.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 05/04/2016 02:56 PM, H. Peter Anvin wrote:
>> Beware that shifting by an amount >= the number of bits in the
>> word remains Undefined Behavior.

> This construct has been supported as a rotate since at least gcc2.

How then should we understand the story told in commit d7e35dfa?
Is the story wrong?

At the very least, something inconsistent is going on. There
are 8 functions. Why did d7e35dfa change one of them but
not the other 7?

Next message: Bjorn Helgaas: "Re: [PATCH [RFC]] PCI: hv: add explicit fencing to config space access"
Previous message: Grochowalski, Matthew (GE Aviation, US): "sched: Where to queue RT tasks on prio drop"
In reply to: H. Peter Anvin: "Re: [PATCH 1/3] random: replace non-blocking pool with a Chacha20-based CRNG"
Next in thread: Andi Kleen: "Re: linux/bitops.h"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]