Re: [PATCH 3/8] perf build: Add build-test for libunwind cross-platforms support

[Jiri Olsa]

On Fri, May 06, 2016 at 08:59:09AM +0000, He Kuang wrote:
> Currently only test for local libunwind. We should check all supported
> platforms so we can use them to parse perf.data with callchain info on
> different machines.
> 
> Signed-off-by: He Kuang <hekuang@xxxxxxxxxx>
> ---
>  tools/build/Makefile.feature                 |  8 ++++++++
>  tools/build/feature/Makefile                 | 16 ++++++++++++++++
>  tools/build/feature/test-libunwind-aarch64.c | 26 ++++++++++++++++++++++++++
>  tools/build/feature/test-libunwind-arm.c     | 27 +++++++++++++++++++++++++++
>  tools/build/feature/test-libunwind-x86.c     | 27 +++++++++++++++++++++++++++
>  tools/build/feature/test-libunwind-x86_64.c  | 27 +++++++++++++++++++++++++++
>  6 files changed, 131 insertions(+)
>  create mode 100644 tools/build/feature/test-libunwind-aarch64.c
>  create mode 100644 tools/build/feature/test-libunwind-arm.c
>  create mode 100644 tools/build/feature/test-libunwind-x86.c
>  create mode 100644 tools/build/feature/test-libunwind-x86_64.c
> 
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index 9f87861..139e99c 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -49,6 +49,10 @@ FEATURE_TESTS_BASIC :=			\
>  	libslang			\
>  	libcrypto			\
>  	libunwind			\
> +	libunwind-x86			\
> +	libunwind-x86_64		\
> +	libunwind-arm			\
> +	libunwind-aarch64		\
>  	pthread-attr-setaffinity-np	\
>  	stackprotector-all		\
>  	timerfd				\
> @@ -92,6 +96,10 @@ FEATURE_DISPLAY ?=			\
>  	libslang			\
>  	libcrypto			\
>  	libunwind			\
> +	libunwind-x86			\
> +	libunwind-x86_64		\
> +	libunwind-arm			\
> +	libunwind-aarch64		\

I dont think we should display status of libs needed only for cross builds
it'll be OFF for most of the people and create unnecessary tension ;-)

thanks,
jirka