Re: [PATCH 4/8] perf build: Add build-test for debug-frame on arm/arm64

[Jiri Olsa]

On Fri, May 06, 2016 at 08:59:10AM +0000, He Kuang wrote:
> Debug-frame for remote platforms is not related to the host platform,
> so we should test each platform separately.

SNIP

> diff --git a/tools/build/feature/test-libunwind-debug-frame.c b/tools/build/feature/test-libunwind-debug-frame.c
> deleted file mode 100644
> index 0ef8087..0000000
> --- a/tools/build/feature/test-libunwind-debug-frame.c
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -#include <libunwind.h>
> -#include <stdlib.h>
> -
> -extern int
> -UNW_OBJ(dwarf_find_debug_frame) (int found, unw_dyn_info_t *di_debug,
> -				 unw_word_t ip, unw_word_t segbase,
> -				 const char *obj_name, unw_word_t start,
> -				 unw_word_t end);
> -
> -#define dwarf_find_debug_frame UNW_OBJ(dwarf_find_debug_frame)

hum but we still use this in standard libdw unwind
from find_proc_info in util/unwind-libunwind.c

should we keep the generic version as well?

thanks,
jirka