Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size.

[Alex Deucher]

On Fri, May 13, 2016 at 1:36 PM, Muhammad Falak R Wani
<falakreyaz@xxxxxxxxx> wrote:
> It is preferred to use ARRAY_SIZE() for size calculation, instead
> using sizeof(array)/sizeof(*array). It makes the code more readable.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
> index da18f44..87c023e 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c
> @@ -639,7 +639,7 @@ static int cz_smu_populate_firmware_entries(struct pp_smumgr *smumgr)
>
>         cz_smu->driver_buffer_length = 0;
>
> -       for (i = 0; i < sizeof(firmware_list)/sizeof(*firmware_list); i++) {
> +       for (i = 0; i < ARRAY_SIZE(firmware_list); i++) {
>
>                 firmware_type = cz_translate_firmware_enum_to_arg(smumgr,
>                                         firmware_list[i]);
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel