Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size.

From: Muhammad Falak R Wani
Date: Tue May 17 2016 - 02:28:44 EST


On Mon, May 16, 2016 at 04:53:50PM +0100, Eric Engestrom wrote:
> On Fri, May 13, 2016 at 11:06:40PM +0530, Muhammad Falak R Wani wrote:
> > It is preferred to use ARRAY_SIZE() for size calculation, instead
> > using sizeof(array)/sizeof(*array). It makes the code more readable.
> >
> > Signed-off-by: Muhammad Falak R Wani <falakreyaz@xxxxxxxxx>
>
> Reviewed-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>
>
> Thanks, and sorry about before, if I made you feel like you made
> a "childish mistake". As Dan said, this is mostly a question of
> style: your code was right, it just had an unnecessary bit.
>
> I hope I didn't give you a bad impression of the community, most
> people around here have better manners than I :P
>
> Cheers
Thank you for such a nice gesture. No, I didn't get any bad impression.
Infact people learn like this.

Thank you guys :)