Re: [PATCH] usb: echi-hcd: Add register access check in shutdown

From: Srinivas Kandagatla
Date: Wed May 18 2016 - 13:57:55 EST




On 18/05/16 15:56, Alan Stern wrote:
This doesn't seem like the right place. What you really should do is
skip calling ehci_silence_controller() if the hardware isn't
accessible. That's where the hardware gets touched, not in
ehci_shutdown().

Just tried this suggestion, this would not work as well, Its not just the hardware registers, which are of concern here, but also the rest of the things like ehci->hrtimer pointer which are allocated or initialized as part of ehci_setup().

Either the msm controller driver is not correct or we should have a way to stop calling ehci_shutdown() if there was no ehci_setup() done yet.

Any suggestions?


--srini