Re: [PATCH v3 12/14] staging: comedi: daqboard2000: rename reference DACs register macros

From: Ian Abbott
Date: Thu May 19 2016 - 06:07:39 EST


On 19/05/16 10:58, Ian Abbott wrote:
Rename the macros that define values for the reference DACs register to
avoid CamelCase, and to make it clearer which register they are
associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value
`0x0080` that triggers setting one of the references.

Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
---
v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`.
v3: Corrected typo in commit: 0x80 --> 0x0080.
---
drivers/staging/comedi/drivers/daqboard2000.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)

Dammit! I missed the other, glaring typo in the commit. `DAQBOARD2000_REF_DACS_SET` should be `DB2K_REQ_DACS_SET`. I'll post a v4 of this patch. Sorry for the bother.

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-