Re: [PATCH v2 2/2] i2c: qup: support SMBus block read

[Timur Tabi]

Naveen Kaje wrote:
> > > +        tags[len++] = QUP_TAG_V2_DATARD;
> > > +        /* 0 implies 256 bytes */
> > > +        if (data_len == QUP_READ_LIMIT)
> > > +            tags[len++] = 0;
> > > +        else
> > > +            tags[len++] = data_len;
> > > +    }
> >         Even data_len will always be '1' right ?
> Yes, but here preferably we use a variable than a number without a context.

Actually, I would say the opposite.  I would rather see a constant with 
a comment explaining it, than a variable that we know will always 
contain only one number.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.