Re: [PATCH v5 4/5] mmc: debugfs: add HS400 enhanced strobe description

[Shawn Lin]

å 2016/5/24 4:56, Doug Anderson åé:
> Shawn,
>
> On Sun, May 22, 2016 at 9:14 PM, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
> > We introduce HS400 with enhanced strobe function, so we need
> > to add it for debug show.
> >
> > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> > ---
> >
> > Changes in v5: None
> > Changes in v4: None
> > Changes in v3: None
> > Changes in v2: None
> >
> >  drivers/mmc/core/debugfs.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c
> > index 9382a57..51d7c38 100644
> > --- a/drivers/mmc/core/debugfs.c
> > +++ b/drivers/mmc/core/debugfs.c
> > @@ -148,7 +148,9 @@ static int mmc_ios_show(struct seq_file *s, void *data)
> >                 str = "mmc HS200";
> >                 break;
> >         case MMC_TIMING_MMC_HS400:
> > -               str = "mmc HS400";
> > +               mmc_card_hs400es(host->card) ?
> > +                       (str = "mmc HS400 enhanced strobe") :
> > +                       (str = "mmc HS400");
>
> Not sure it's terribly important, but I've typically seen this as:
>
> str = mmc_card_hs400es(host->card) ?
>           "mmc HS400 enhanced strobe" : "mmc HS400";
>
> AKA: don't repeat the "str ="

Thanks for your review and test. I wanna wait for some more days
to see if there are any other comments for this patchset.


> I doubt it really matters that much, though, so:
>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>


--
Best Regards
Shawn Lin