Re: [PATCH v5 5/5] mmc: sdhci-of-arasan: implement enhanced strobe callback

[Shawn Lin]

å 2016/5/24 5:00, Doug Anderson åé:
> Shawn,
>
> On Sun, May 22, 2016 at 9:14 PM, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
> > Currently sdhci-arasan 5.1 can support enhanced strobe function,
> > and we now limit it just for "arasan,sdhci-5.1". Add
> > mmc-hs400-enhanced-strobe in DT to enable the function if we're
> > sure our controller can support it.
> >
> > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> > Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> > Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> > ---
> >
> > Changes in v5: None
> > Changes in v4: None
>
> Again, minor, but you did have changes...

yes, it did. I moved all the change-log into the
cover-letter but it seems better to keep them seperately
for each patch. I will do it for the next version if
needed. Thanks.

> > Changes in v3: None
> > Changes in v2: None
> >
> >  drivers/mmc/host/sdhci-of-arasan.c | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
>
> I've tested this patch and it appears to work (not that I've hooked a
> scope up, but since it's not doing tuning I think it would be pretty
> obvious if it didn't work).
>
> Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>


--
Best Regards
Shawn Lin