Re: [RFC][PATCH 2/3] locking: Annotate spin_unlock_wait() users
From: Peter Zijlstra
Date: Tue May 24 2016 - 12:59:00 EST
On Tue, May 24, 2016 at 12:22:07PM -0400, Tejun Heo wrote:
> A delta but that particular libata usage is probably not needed now.
> The path was used while libata was gradually adding error handlers to
> the low level drivers. I don't think we don't have any left w/o one
> at this point. I'll verify and get rid of that usage.
OK, that would be great; I was sorta lost in there, but it looked like
if you need the spin_unlock_wait() you also need the extra barrier
If you can remove it, better still.