Re: [RFC][PATCH 2/3] locking: Annotate spin_unlock_wait() users

From: Tejun Heo
Date: Wed May 25 2016 - 15:28:15 EST

On Tue, May 24, 2016 at 06:58:36PM +0200, Peter Zijlstra wrote:
> On Tue, May 24, 2016 at 12:22:07PM -0400, Tejun Heo wrote:
> > A delta but that particular libata usage is probably not needed now.
> > The path was used while libata was gradually adding error handlers to
> > the low level drivers. I don't think we don't have any left w/o one
> > at this point. I'll verify and get rid of that usage.
> OK, that would be great; I was sorta lost in there, but it looked like
> if you need the spin_unlock_wait() you also need the extra barrier
> thing.
> If you can remove it, better still.

Unfortunately, ipr SAS driver is still using the old error handling
path, so please include libata in the conversion for now. I'll see if
ipr can be converted.