Re: [PATCH 00/10] String hash improvements
From: George Spelvin
Date: Wed May 25 2016 - 05:07:53 EST
>> +#if defined(CONFIG_M68000) || defined(CONFIG_M68010)
> As I said before, I don't think you need this check, given HAVE_ARCH_HASH is
> selected by M68000, and M68010 doesn't exist.
I was going belt & suspenders on general principles, but yes, I'm happy
to leave it out.
I noticed that CONFIG_M68010 doesn't exist in Linus' tree, but you
recommended it, so I thought you might know something I don't.
> As you only include <asm/archhash.h> if CONFIG_HAVE_ARCH_HASH
> is defined, you can also just call the arch-specific one <asm/hash.h>.
Yes, that's a possibility, too. But weren't we still discussing whether
I should use conditional #inclusion based on a symbol, or asm-generic?
If neither of us has a killer argument that convinces the other, style
issues like this are amenable to voting, so I was going to wait a little
bit for others to chime in.
Thank you very much for the comments!