Re: [PATCH V3 0/2] usb: musb: fix dropped packets

From: Bin Liu
Date: Wed May 25 2016 - 16:08:03 EST


Hi,

On Tue, May 24, 2016 at 09:22:32AM +0100, Andrew Goodbody wrote:
> The musb driver can drop rx packets when heavily loaded. These two
> patches address two issues that can cause this. Both issues arose
> when an endpoint was reprogrammed. The first patch is a logic bug
> that resulted in a shared_fifo in rx mode not having its state
> cleared out. The second patch fixes a race condition caused by
> not stopping the dedicated endpoint for bulk packets before
> rotating its queue which allowed a packet to be recieved and then
> thrown away.
>
> V3 Updated the comment to better reference the manual
> V2 added a comment and removed debugging code
>
> Andrew Goodbody (2):
> usb: musb: Ensure rx reinit occurs for shared_fifo endpoints
> usb: musb: Stop bulk endpoint while queue is rotated

Signed-off-by: Bin Liu <b-liu@xxxxxx>

Regards,
-Bin.

>
> drivers/usb/musb/musb_host.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
>
> --
> 2.7.4
>