Re: [PATCH 5/7] zram: use crypto api to check alg availability

From: Minchan Kim
Date: Fri May 27 2016 - 05:06:03 EST

On Fri, May 27, 2016 at 04:43:45PM +0800, Herbert Xu wrote:
> On Fri, May 27, 2016 at 05:27:44PM +0900, Minchan Kim wrote:
> >
> > Yes, it might be trivial to adding new "string" into the backend array
> > if we consider frequency of adding new compressoin algorithm in linux
> > but it would be better if we can get names of supported compression
> > algorithm name by crypto API.
> >
> > If it's not good idea or something hard to implement, let's go with
> > hardcoding.
> >
> > Herbert, Could you give us thought?
> It is fundamentally impossible to get a list of all *potential*
> algorithms if you allow loadable modules. By definition someone
> could load a new module and thus introduce a new algorithm.

Thanks for the quick response. I understand now.


Then, shouldn't we add functionality to load new algorithm although
there is no entry in zcomp backend array?

The main reason we changed to crypto is to support various compression
algorithm for zram so we should be able to support anyone who want to
use custom crypto compression module.

A idea is that let's not adding new compression string into backend
array from now on and deprecates /zram/comp_algorithm to show name.
So, from now on, users should be aware of the compression naming and
load module by oneself. It's not kind but I hope admins already knows
what cryto compressor they have.

I don't have better idea.

> Given a specific algorithm name you could determine whether it
> is present on the system.
> Cheers,
> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page:
> PGP Key: