Re: [PATCH v3 4/4] soc: Add SoC driver for Freescale Vybrid platform

From: maitysanchayan
Date: Fri May 27 2016 - 06:15:12 EST


On 16-05-27 10:31:55, Arnd Bergmann wrote:
> On Friday, May 27, 2016 12:03:01 PM CEST maitysanchayan@xxxxxxxxx wrote:
> >
> > So if I understand correctly, the binding at the SoC level is fine.
> > Keeping that but removing the additional made-up properties, viz. below
> >
> > rom-revision: phandle to the on-chip ROM node
> > mscm: phandle to the MSCM CPU configuration node
> > nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1
> > nvmem-cell-names: should contain string names "cfg0" and "cfg1"
> >
> > would be fine?
> >
> > We would have something similar to here
> > http://www.spinics.net/lists/devicetree/msg80655.html
> >
> > but now with the DT binding under SoC bus.
> >
>
>
> You look up the OTP device as a syscon here, which seems odd since there
> is already an nvmem driver for it. Shouldn't you use the nvmem API for
> that?
>
> Arnd

I need the following

nvmem-cells: phandles to two OCOTP child nodes ocotp_cfg0 and ocotp_cfg1
nvmem-cell-names: should contain string names "cfg0" and "cfg1"

to be able to use the NVMEM consumer API.

If I can put them at SoC node level then I certainly can use the NVMEM API.

Regards,
Sanchayan.