Re: [PATCH 4/5] spi: sunxi: set maximum and minimum speed of SPI master
From: Maxime Ripard
Date: Mon May 30 2016 - 05:17:30 EST
On Thu, May 26, 2016 at 07:25:25PM -0000, Michal Suchanek wrote:
> The maximum speed of SPI master is used when maximum speed of SPI slave
> is not specified. Also the __spi_validate function should check that
> transfer speeds do not exceed the master limits.
> The user manual for A10 and A31 specifies maximum
> speed of the SPI clock as 100MHz and minimum as 3kHz.
> Setting the SPI clock to out-of-spec values can lock up the SoC.
> Signed-off-by: Michal Suchanek <hramrach@xxxxxxxxx>
> drivers/spi/spi-sun4i.c | 2 ++
> drivers/spi/spi-sun6i.c | 2 ++
> 2 files changed, 4 insertions(+)
> diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c
> index bf52b09..e1a75dd6 100644
> --- a/drivers/spi/spi-sun4i.c
> +++ b/drivers/spi/spi-sun4i.c
> @@ -405,6 +405,8 @@ static int sun4i_spi_probe(struct platform_device *pdev)
> sspi->master = master;
> + master->max_speed_hz = 100*1000*1000;
You need spaces around the * operator.
> + master->min_speed_hz = 3*1000;
And I'm not exactly sure why you have that weird indentation.
The same applies for the sun6i driver
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
Description: PGP signature