Re: [PATCH] iwlwifi: mvm: avoid harmless -Wmaybe-uninialized warning
From: Coelho, Luciano
Date: Mon May 30 2016 - 16:37:16 EST
On Fri, 2016-05-27 at 15:07 +0200, Arnd Bergmann wrote:
> gcc is apparently unablel to track the state of the local 'resp_v2'
> variable across the kzalloc() function, and warns about the response
> variable being used without an initialization:
> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c: In function
> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:727:36: warning:
> âmcc_resp_v1â may be used uninitialized in this function [-Wmaybe-
> ÂÂÂresp_cp->n_channels = mcc_resp_v1->n_channels;
> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:721:3: warning:
> âmcc_respâ may be used uninitialized in this function [-Wmaybe-
> ÂÂÂmemcpy(resp_cp, mcc_resp, resp_len);
> The warning showed up in x86 allmodconfig after my patch to
> unhide -Wmaybe-uninitialized warnings by default was merged,
> though it always existed in randconfig builds. I did not
> catch the warning earlier because I was testing on ARM, which
> never produced the warning.
> This rearranges the code in a way that improves readability for
> both humans and the compiler, and that avoids the warning.
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Fixes: 6fa52430f0b3 ("iwlwifi: mvm: change mcc update API")
Thanks, Arnd! I queued this via our internal tree.