Re: [PATCH perf/core v9 01/16] perf-symbol: Introduce filename__readable to check readability
From: Masami Hiramatsu
Date: Tue May 31 2016 - 01:54:53 EST
On Mon, 30 May 2016 13:04:47 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> Em Mon, May 30, 2016 at 01:03:17PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Sun, May 29, 2016 at 12:15:13AM +0900, Masami Hiramatsu escreveu:
> > > Introduce filename__readable to check readability by opening
> > > the file directly. Since the access(R_OK) just checks the
> > > readability based on real UID/GID, it is ignored that the
> > > effective UID/GID and capabilities for some special file (e.g.
> > > /proc/kcore).
> > > filename__readable() directly opens given file with O_RDONLY
> > > so that the kernel checks it by effective UID/GID and capabilities.
> > You missed the Signed-off-by line.
> This this for you this time, no need to resend.
Oops, and thanks!!
> - Arnaldo
Masami Hiramatsu <mhiramat@xxxxxxxxxx>