Re: [PATCH 3/3] ARM: dts: exynos: Add watchdog amd Security SubSystem to Exynos5410

[Javier Martinez Canillas]

Hello Krzysztof,

On 06/01/2016 05:45 AM, Krzysztof Kozlowski wrote:
> Move watchdog and Security SubSystem nodes from exynos5420.dtsi to file
> shared with Exynos5410 and configure the clocks on the latter.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---

[snip]

>  
> +&sss {
> +	clocks = <&clock CLK_SSS>;
> +	clock-names = "secss";
> +};
> +

[snip]

>  
> +&watchdog {
> +	clocks = <&clock CLK_WDT>;
> +	clock-names = "watchdog";
> +	samsung,syscon-phandle = <&pmu_system_controller>;
> +};
> +

Since you used the same ID than Exynos5420 for the SSS and WDT clocks,
I wonder if the clock and clock-names shouldn't be just defined in the
shared exynos54xx.dtsi as is the case for the interrupts that are also
the same?

The patch looks good to me though, so whatever you decide:

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America